On Fri, Jul 03, 2020 at 08:45:42PM +0200, Sam Ravnborg wrote: > Use the backlight_is_blank() helper to simplify the code a bit. > This add support for fb_blank as a side-effect. > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: Lee Jones <lee.jones@xxxxxxxxxx> > Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > Cc: Jingoo Han <jingoohan1@xxxxxxxxx> This driver exhibits the "how does userspace know what writing brightness zero to sysfs actually does" problem so can't use the backlight_get_brightness() helper. If you respin it would be good to see that in the patch description but that's such an extreme nitpick It think, either way, this can be: Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> Daniel. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
