Re: [PATCH] drm/of: Consider the state in which the ep is disabled

[Huang Jiachai <hjc@xxxxxxxxxxxxxx>]

Hi heiko

在 2020/7/6 17:47, Heiko Stübner 写道:

> Hi Sandy,
>
> Am Montag, 6. Juli 2020, 09:59:44 CEST schrieb Sandy Huang:
> > don't mask possible_crtcs if remote-point is disabled.
> >
> > Signed-off-by: Sandy Huang <hjc@xxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/drm_of.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > index fdb05fbf72a0..f5f250435add 100644
> > --- a/drivers/gpu/drm/drm_of.c
> > +++ b/drivers/gpu/drm/drm_of.c
> > @@ -66,6 +66,11 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> >  	uint32_t possible_crtcs = 0;
> >  
> >  	for_each_endpoint_of_node(port, ep) {
> > +		if (!of_device_is_available(ep)) {
> > +			of_node_put(ep);
> >       
> You'd only need the of_node_put here, if you were exiting the loop.
>
> With the "continue" below, the next iteration of for_each_endpoint_of_node
> will do the put on "ep"
>     
    Just as we communicate on the google talk, the v2
      patch will delete of_node_put(ep) and leave continue, thanks.
    
> Heiko
>
> > +			continue;
> > +		}
> > +
> >  		remote_port = of_graph_get_remote_port(ep);
> >  		if (!remote_port) {
> >  			of_node_put(ep);
> >
> >       
>
>
>
>
>
>     
-- 
Best Regard 

黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
      No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel：+86 0591-87884919  8690
E-mail：hjc@xxxxxxxxxxxxxx
  

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel