Re: [PATCH v2 6/8] drm/amdgpu: Unmap entire device address space on device remove.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 6/23/20 9:16 AM, Christian König wrote:
Am 23.06.20 um 12:22 schrieb Daniel Vetter:
On Mon, Jun 22, 2020 at 03:48:29PM -0400, Alex Deucher wrote:
On Mon, Jun 22, 2020 at 3:38 PM Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky:
Use the new TTM interface to invalidate all exsisting BO CPU mappings
form all user proccesses.

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx>
Reviewed-by: Christian König <christian.koenig@xxxxxxx>

I think those two patches could already land in amd-staging-drm-next
since they are a good idea independent of how else we fix the other issues.
Please make sure they land in drm-misc as well.
Not sure that's much use, since without any of the fault side changes you
just blow up on the first refault. Seems somewhat silly to charge ahead on
this with the other bits still very much under discussion.

Well what I wanted to say is that we don't need to send out those simple patches once more.

Plus I suggested a possible bikeshed here :-)

No bikeshed, but indeed a rather good idea to not make this a TTM function.

Christian.


So i will incorporate the changes suggested to turn the TTM part into generic DRM helper and will resend both patches as part of V3 (which might take a while now due to a context switch I am doing for another task).

Andrey



-Daniel

Alex

---
   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
   1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 43592dc..6932d75 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1135,6 +1135,7 @@ amdgpu_pci_remove(struct pci_dev *pdev)
       struct drm_device *dev = pci_get_drvdata(pdev);

       drm_dev_unplug(dev);
+ ttm_bo_unmap_virtual_address_space(&adev->mman.bdev);
       amdgpu_driver_unload_kms(dev);

       pci_disable_device(pdev);

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux