On Tue 2020-06-16 09:28:19, Sasha Levin wrote: > On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote: > > Hi! > > > > > > The driver creates the /dev/dxg device, which can be opened by user mode > > > > application and handles their ioctls. The IOCTL interface to the driver > > > > is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl > > > > definitions). The interface matches the D3DKMT interface on Windows. > > > > Ioctls are implemented in ioctl.c. > > > > > > Echoing what others said, you're not making a DRM driver. The driver should live outside > > > of the DRM code. > > > > > > > Actually, this sounds to me like "this should not be merged into linux kernel". I mean, > > we already have DRM API on Linux. We don't want another one, do we? > > This driver doesn't have any display functionality. Graphics cards without displays connected are quite common. I may be wrong, but I believe we normally handle them using DRM... > > And at the very least... this misses API docs for /dev/dxg. Code can't really > > be reviewed without that. > > The docs live here: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/d3dkmthk/ I don't see "/dev/dxg" being metioned there. Plus, kernel API documentation should really go to Documentation, and be suitably licensed. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
