Re: [PATCH] drm/mgag200: Don't set <rammapen> in MISC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thomas,

On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
>
> The original modesetting code set MISC to 0x2d, which is <hpgoddev>,
> <clksel> and <ioaddsel>
>
> With the conversion to atomic modesetting, <rammapen> accidentally
> got enabled as well. Revert this change and initialize MISC with a
> constant value of <hgoddev> and <ioaddsel>. The <clksel> bits are set
> in mga_crtc_set_plls(), sync flags are set in mgag200_set_mode_regs().
>

Let's keep the remove (restoring original functionality) and rename
(cosmetics) separate patches. The read has also disappeared, which
should be safe although might be better on it's own.

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux