On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost <navid.emamdoost@xxxxxxxxx> wrote: ... > + if (ret < 0) { > + pm_runtime_put(gpu->dev); Please, in all your patches fix this to be _put_noidle(). We wouldn't bear the flag day of fixing these parts again. Yes, I know that *now* behaviour is the same, but calling put here is slightly inconsistent. ... > + pm_runtime_put(gpu->dev); -- With Best Regards, Andy Shevchenko _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel