* Tomi Valkeinen <tomi.valkeinen@xxxxxx> [200609 16:27]: > On 09/06/2020 19:10, Tony Lindgren wrote: > > Yeah so it seems. Can we just diconnect the display outputs > > in .prepare somewhere? Or is that the wrong place to do it? > > Hmm, yes, perhaps... If omapdrm uses .prepare to disable all the outputs. > Then DSS submodules could use UNIVERSAL_DEV_PM_OPS() and have the same > functions for system and runtime suspend. Yeah that would be nice. And maybe the need for force_suspend also disappears with the ordering issues gone :) > Although that has the problem that if the DSS is already runtime suspended > when system suspend happens, the PM does not wake DSS up, and thus the > suspend callbacks will crash if they access registers. So they need some > extra logic there. > > I'll see tomorrow if I can come up with something like that. OK. This $subject patch works for my test cases for suspend and resume based on a brief test with my fixes branch FYI. Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
