On Sat, Jun 06, 2020 at 10:25:45PM +0200, Hans de Goede wrote: > Hi All, > > This patch series converts the i915 driver's cpde for controlling the > panel's backlight with an external PWM controller to use the atomic PWM API. > > Initially the plan was for this series to consist of 2 parts: > 1. convert the pwm-crc driver to support the atomic PWM API and > 2. convert the i915 driver's PWM code to use the atomic PWM API. > > But during testing I've found a number of bugs in the pwm-lpss and I > found that the acpi_lpss code needs some special handling because of > some ugliness found in most Cherry Trail DSDTs. > > So now this series has grown somewhat large and consists of 4 parts: > > 1. acpi_lpss fixes workarounds for Cherry Trail DSTD nastiness > 2. various fixes to the pwm-lpss driver > 3. convert the pwm-crc driver to support the atomic PWM API and > 4. convert the i915 driver's PWM code to use the atomic PWM API > > So we need to discuss how to merge this (once it passes review). > Although the inter-dependencies are only runtime I still think we should > make sure that 1-3 are in the drm-intel-next-queued (dinq) tree before > merging the i915 changes. Both to make sure that the intel-gfx CI system > does not become unhappy and for bisecting reasons. Simplest is if acpi acks the acpi patches for merging through drm-intel.git. Second simplest is topic branch (drm-intel maintainers can do that) with the entire pile, which then acpi and drm-intel can both pull in. Up to the two maintainer teams to figure this one out. /me out Cheers, Daniel > > The involved acpi_lpss and pwm drivers do not see a whole lot of churn, > so we could just merge everything through dinq, or we could use immutable > branch and merge those into dinq. > > So Rafael and Thierry, can I either get your Acked-by for directly merging > this into dinq, or can you provide an immutable branch with these patches? > > This series has been tested (and re-tested after adding various bug-fixes) > extensively. It has been tested on the following devices: > > -Asus T100TA BYT + CRC-PMIC PWM > -Toshiba WT8-A BYT + CRC-PMIC PWM > -Thundersoft TS178 BYT + CRC-PMIC PWM, inverse PWM > -Asus T100HA CHT + CRC-PMIC PWM > -Terra Pad 1061 BYT + LPSS PWM > -Trekstor Twin 10.1 BYT + LPSS PWM > -Asus T101HA CHT + CRC-PMIC PWM > -GPD Pocket CHT + CRC-PMIC PWM > > Regards, > > Hans > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
