On 4/22/20 6:07 PM, Dejin Zheng wrote: > the sfb->fb->screen_base is not save the value get by iounmap() when > the chip id is 0x720. so iounmap() for address sfb->fb->screen_base > is not right. > > Fixes: 1461d6672864854 ("staging: sm7xxfb: merge sm712fb with fbdev") > CC: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx> Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c > index 6a1b4a853d9e..8cd655d6d628 100644 > --- a/drivers/video/fbdev/sm712fb.c > +++ b/drivers/video/fbdev/sm712fb.c > @@ -1429,6 +1429,8 @@ static int smtc_map_smem(struct smtcfb_info *sfb, > static void smtc_unmap_smem(struct smtcfb_info *sfb) > { > if (sfb && sfb->fb->screen_base) { > + if (sfb->chip_id == 0x720) > + sfb->fb->screen_base -= 0x00200000; > iounmap(sfb->fb->screen_base); > sfb->fb->screen_base = NULL; > } > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel