HI Laurent, >From a quick glance the series looks really good and neat. Then again, I don't know much about the hardware to provide meaningful review. A couple of small ideas below. On Sat, 30 May 2020 at 04:11, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > +#define LCDC_AS_BUF 0x220 > +#define LCDC_AS_NEXT_BUF 0x230 s/LCDC_AS_BUF/LCDC_AS_CUR_BUF/ - to stay consistent with the primary plane name scheme. Would it make sense to store the above registers in mxsfb_devdata, just like we do for the primary planes? HTH Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
