Re: [PATCH v2 2/2] drm/auth: make drm_{set, drop]master_ioctl symmetrical

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 30 May 2020 at 14:18, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> Hi Emil.
> On Sat, May 30, 2020 at 01:46:40PM +0100, Emil Velikov wrote:
> > Currently the ret handling is all over the place - with two redundant
> > assignments and another one addressed earlier.
> >
> > Use the exact same flow in both functions.
> >
> > v2: straighten the code flow, instead of just removing the assignments
> Now even I should be able to follow the flow - thanks :-)
>
Fwiw reading at the code the first couple of times, did confuse the
hell out of me.
So "there is nothing wrong with your television set" :-P

> >
> > Cc: David Airlie <airlied@xxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> > Signed-off-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>
> Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

Thanks. If you're up for a few more neat patches - check these out [1].

-Emil

[1] https://patchwork.freedesktop.org/series/76967/
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux