Re: [PATCH 09/21] drm: mxsfb: Remove unneeded includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefan,

On Mon, Mar 23, 2020 at 10:53:50PM +0100, Stefan Agner wrote:
> On 2020-03-09 20:52, Laurent Pinchart wrote:
> > A fair number of includes are not needed. Drop them, and add a couple of
> > required includes that were included indirectly.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> 
> Out of curiosity, do you have some kind of tool helping with this?

No, that was manual.

> Reviewed-by: Stefan Agner <stefan@xxxxxxxx>
> 
> > ---
> >  drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 +++---------
> >  drivers/gpu/drm/mxsfb/mxsfb_drv.c  |  5 -----
> >  2 files changed, 3 insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > index aef72adabf41..c4f1575b4210 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > @@ -10,19 +10,13 @@
> >  
> >  #include <linux/clk.h>
> >  #include <linux/iopoll.h>
> > -#include <linux/of_graph.h>
> > -#include <linux/platform_data/simplefb.h>
> > +#include <linux/spinlock.h>
> >  
> > -#include <video/videomode.h>
> > -
> > -#include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_bridge.h>
> >  #include <drm/drm_crtc.h>
> >  #include <drm/drm_fb_cma_helper.h>
> > -#include <drm/drm_fb_helper.h>
> > +#include <drm/drm_fourcc.h>
> >  #include <drm/drm_gem_cma_helper.h>
> > -#include <drm/drm_of.h>
> > -#include <drm/drm_plane_helper.h>
> > -#include <drm/drm_probe_helper.h>
> >  #include <drm/drm_simple_kms_helper.h>
> >  #include <drm/drm_vblank.h>
> >  
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > index cffc70257bd3..204c1e52e9aa 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > @@ -9,15 +9,10 @@
> >   */
> >  
> >  #include <linux/clk.h>
> > -#include <linux/component.h>
> >  #include <linux/dma-mapping.h>
> > -#include <linux/list.h>
> >  #include <linux/module.h>
> >  #include <linux/of_device.h>
> > -#include <linux/of_graph.h>
> > -#include <linux/of_reserved_mem.h>
> >  #include <linux/pm_runtime.h>
> > -#include <linux/dma-resv.h>
> >  #include <linux/spinlock.h>
> >  
> >  #include <drm/drm_atomic.h>

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux