Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@xxxxxxxxxxxxx>
On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
> There is no point to print deferred probe (and its failures to get
> resources) as an error. Also there is no need to print regulator errors
> twice.
>
> In case of multiple probe tries this would pollute the dmesg.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Reviewed-by: Steven Price <steven.price@xxxxxxx>
>
> ---
>
> Changes since v2:
> 1. Rebase
> 2. Add Steven's review
>
> Changes since v1:
> 1. Remove second error message from calling panfrost_regulator_init()
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 8136babd3ba9..b172087eee6a 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
> pfdev->comp->num_supplies,
> pfdev->regulators);
> if (ret < 0) {
> - dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(pfdev->dev, "failed to get regulators: %d\n",
> + ret);
> return ret;
> }
>
> @@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
> }
>
> err = panfrost_regulator_init(pfdev);
> - if (err) {
> - dev_err(pfdev->dev, "regulator init failed %d\n", err);
> + if (err)
> goto err_out0;
> - }
>
> err = panfrost_reset_init(pfdev);
> if (err) {
> --
> 2.17.1
>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
