Re:Re: [PATCH] drm: fix setting of plane_mask in pan_display_atomic() function for linux-4.4

[chenxb_99091 <chenxb_99091@xxxxxxx>]

--
发自我的网易邮箱手机智能版

<br/><br/><br/>


----- Original Message -----
From: "Daniel Vetter" <daniel@xxxxxxxx>
To: chenxb_99091@xxxxxxx
Cc: "David Airlie" <airlied@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx
Sent: Mon, 25 May 2020 16:34:28 +0200
Subject: Re: [PATCH] drm: fix setting of plane_mask in pan_display_atomic() function for linux-4.4

>On Sat, May 23, 2020 at 11:49:07AM +0800, chenxb_99091@xxxxxxx wrote:
> >From: Xuebing Chen <chenxb_99091@xxxxxxx>
>  >
>>The <include/drm/drm_crtc.h> provides drm_for_each_plane_mask macro and
>>plane_mask is defined as bitmask of plane indices, such as
>>1<<drm_plane_index(plane). This patch fixes error setting of plane_mask
> >in pan_display_atomic() function.
>  >
> >Signed-off->>by: Xuebing Chen <chenxb_99091@xxxxxxx>

>What kernel is this patch against? Latest upstream doesn't have any such
>code anymore ... I'm assuming that Ville fixed this in one of his patches,
>but I can't find the right one just now.
>-Danie

This bug is still present in the long-supported versions of kernel 4.4.y,  including the latest kernel 4.4.224,see https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/?h=v4.4.224

> >---
> > drivers/gpu/drm/drm_fb_helper.c | 2 +-
>  >1 file changed, 1 insertion(+), 1 deletion(-)
>  >
> >diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> >index e449f22..6a9f7ee 100644
>> --- a/drivers/gpu/drm/drm_fb_helper.c
> >+++ b/drivers/gpu/drm/drm_fb_helper.c
>> @@ -1256,7 +1256,7 @@ retry:
> >    goto fail;
>>   
>  >  plane = mode_set->crtc->primary;
>> - plane_mask |= drm_plane_index(plane);
> >+ plane_mask |= 1 << drm_plane_index(plane);
>>    plane->old_fb = plane->fb;
>  > }
>  > 
>> -- 
> >2.7.4
>  >
>> _______________________________________________
>> dri-devel mailing list
> >dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
>Daniel Vetter
>Software Engineer, Intel Corporation
>http://blog.ffwll.ch

 

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel