On Mon, 18 May 2020 at 10:22, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > > On Sun, 17 May 2020, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: > > On Thu, 17 Aug 2017 at 12:34, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > >> > >> On Thu, 17 Aug 2017, Michael Tretter <m.tretter@xxxxxxxxxxxxxx> wrote: > >> > Using plain echo to set the "force" connector attribute fails with > >> > -EINVAL, because echo appends a newline to the output. > >> > > >> > Replace strcmp with sysfs_streq to also accept strings that end with a > >> > newline. > >> > > >> > v2: use sysfs_streq instead of stripping trailing whitespace > >> > > >> > Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx> > >> > >> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > >> > > Seems like this fell through the cracks. Pushed to drm-misc-next. > > From 2017? How'd you find it? :o > > My bad, thanks. > A colleague mentioned about their experiences with \n, so I remembered seeing something. >From a quick grep, we have have handful of other cases mostly in amdgpu and radeon. Will see it I can prep a patch later on today. -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel