On Thu, May 14, 2020 at 05:39:57PM -0700, Matthias Kaehlcke wrote: > On Thu, May 14, 2020 at 04:24:17PM +0530, Sharat Masetty wrote: > > This patch changes the plumbing to send the devfreq recommended opp rather > > than the frequency. Also consolidate and rearrange the code in a6xx to set > > the GPU frequency and the icc vote in preparation for the upcoming > > changes for GPU->DDR scaling votes. > > Could this be relatively easily split in two patches, one passing the OPP > instead of the frequency, and another doing the consolidation? It typically > makes reviewing easier when logically unrelated changes are done in separate > patches. After looking at the "upcoming changes for GPU->DDR scaling votes", which is essentially one line I'm doubting if the splitting would actually make sense. I'm now rather inclined to see "drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth" squashed into this patch. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
