Hi Hans, On Thu, 30 Apr 2020 at 15:55, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 4/30/20 4:52 PM, Ville Syrjälä wrote: > > On Thu, Apr 30, 2020 at 02:47:00PM +0100, Emil Velikov wrote: > >> Hi Hans, > >> > >> On Fri, 21 Feb 2020 at 17:33, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >>> > >>> drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching > >>> a video= argument over calculating our own timings for the user specified > >>> mode using CVT or GTF. > >>> > >>> But userspace code which is auto-configuring the mode may want to know that > >>> the user has specified that mode on the kernel commandline so that it can > >>> pick that mode over the mode which is marked as DRM_MODE_TYPE_PREFERRED. > >>> > >>> This commit sets the DRM_MODE_TYPE_USERDEF flag on the matching mode, just > >>> as we would do on the user-specified mode when no matching probed mode is > >>> found. > >>> > >>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > >> > >> I was skimming around wrt Ville's compact drm_display_mode series and > >> noticed that this never landed. > >> > >> The commit brings extra consistency when dealing with user defined > >> modes, and is: > >> Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > >> > >> Ville this may trivially conflict with your work. I suspect you can do > >> the honours, and apply on top of your series? > >> That is if you agree with the patch. > > > > Quick glance at the original thread says maybe there were still some > > userspace issues unresolved? Not sure. > > IIRC the thread ended with Daniel agreeing on the userspace interface, > but asking for some docs and me pointing out that the patch already > updated/clarified the existing docs. After that things got quiet. > > So I believe that this is (still) ready to go upstream. > Having read through the full discussion, couple of times, I believe you're spot on. Daniel requested documentation, which the patch provides. I'd say let's poke him on IRC a few times, if he doesn't object let's push it? -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
