On Tue, 12 May 2020 at 19:34, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > Hi Emil > > Am 12.05.20 um 12:27 schrieb Emil Velikov: > > Hi Thomas, > > > > On Tue, 12 May 2020 at 09:43, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > > >> @@ -1143,20 +1178,15 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, > >> WREG_CRT(13, 0); > >> WREG_CRT(14, 0); > >> WREG_CRT(15, 0); > >> - WREG_CRT(19, pitch & 0xFF); > >> - > > This write has disappeared without an equivalent or a comment. > > Is that intentional? > > It's still there. It's now located in mgag200_set_offset() and 19 is > written as 0x13. :) I try to follow the naming style of the MGA > programming manual, which prefers hexadecimal numbers. > D'oh, didn't register the dec->hex change. Thanks -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
