On Tue, 12 May 2020 at 09:43, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > The VRAM helpers managed the framebuffer memory for mgag200. This came > with several problems, as some MGA device require the scanout address > to be located at VRAM offset 0. It's incompatible with the page-flip > semantics of DRM's atomic modesettting. With atomic modesetting, old and > new framebuffers have to be located in VRAM at the same time. So at least > one of them has to reside at a non-0 offset. > > This patch replaces VRAM helpers with SHMEM helpers. GEM SHMEM buffers > reside in system memory, and are shadow-copied into VRAM during page > flips. The shadow copy always starts at VRAM offset 0. > I suspect MGAG200_FLAG_HW_BUG_NO_STARTADD is left around for documentation purposes? I've made a few small comments, but regardless the series is: Acked-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel