On 5/8/20 7:40 AM, Arnd Bergmann wrote: > CONFIG_DEVICE_PRIVATE cannot be selected in configurations > without ZONE_DEVICE: > > WARNING: unmet direct dependencies detected for DEVICE_PRIVATE > Depends on [n]: ZONE_DEVICE [=n] > Selected by [y]: > - DRM_NOUVEAU_SVM [=y] && HAS_IOMEM [=y] && DRM_NOUVEAU [=y] && MMU [=y] && STAGING [=y] > kernel/resource.c:1653:28: error: use of undeclared identifier 'PA_SECTION_SHIFT' > size = ALIGN(size, 1UL << PA_SECTION_SHIFT); > ^ > kernel/resource.c:1654:48: error: use of undeclared identifier 'MAX_PHYSMEM_BITS' > > Add a dependency for Nouveau to avoid broken randconfig builds. > > Fixes: d2c63df2242e ("mm/hmm: make CONFIG_DEVICE_PRIVATE into a select") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested Thanks. > --- > drivers/gpu/drm/nouveau/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig > index af5793f3e7c2..996ec5475908 100644 > --- a/drivers/gpu/drm/nouveau/Kconfig > +++ b/drivers/gpu/drm/nouveau/Kconfig > @@ -87,6 +87,7 @@ config DRM_NOUVEAU_BACKLIGHT > config DRM_NOUVEAU_SVM > bool "(EXPERIMENTAL) Enable SVM (Shared Virtual Memory) support" > depends on DRM_NOUVEAU > + depends on ZONE_DEVICE > depends on MMU > depends on STAGING > select DEVICE_PRIVATE > -- ~Randy _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel