Am 06.05.2020 18:00 schrieb Alex Deucher <alexdeucher@xxxxxxxxx>:
On Wed, May 6, 2020 at 10:27 AM Zheng Bin <zhengbin13@xxxxxxxxxx> wrote:
>
> Zheng Bin (14):
> drm/radeon: remove comparison to bool in btc_dpm.c
> drm/radeon: remove comparison to bool in ci_dpm.c
> drm/radeon: remove comparison to bool in ni_dpm.c
> drm/radeon: remove comparison to bool in radeon_atpx_handler.c
> drm/radeon: remove comparison to bool in radeon_object.c
> drm/radeon: remove comparison to bool in radeon_ttm.c
> drm/radeon: remove comparison to bool in r100.c
> drm/radeon: remove comparison to bool in r300.c
> drm/radeon: remove comparison to bool in r600.c
> drm/radeon: remove comparison to bool in rs600.c
> drm/radeon: remove comparison to bool in rs690.c
> drm/radeon: remove comparison to bool in rv6xx_dpm.c
> drm/radeon: remove comparison to bool in rv515.c
> drm/radeon: remove comparison to bool in si_dpm.c
Does the checker need to be fixed? All of these are comparing boolean
variables to true/false. Seems like needless code churn to me.
We should probably make sure that no new code like this leaks in, but I also don't see that this is necessary for the old driver stack.
Christian.
Alex
>
> drivers/gpu/drm/radeon/btc_dpm.c | 2 +-
> drivers/gpu/drm/radeon/ci_dpm.c | 4 ++--
> drivers/gpu/drm/radeon/ni_dpm.c | 6 +++---
> drivers/gpu/drm/radeon/r100.c | 2 +-
> drivers/gpu/drm/radeon/r300.c | 2 +-
> drivers/gpu/drm/radeon/r600.c | 3 ++-
> drivers/gpu/drm/radeon/radeon_atpx_handler.c | 4 ++--
> drivers/gpu/drm/radeon/radeon_object.c | 2 +-
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> drivers/gpu/drm/radeon/rs600.c | 2 +-
> drivers/gpu/drm/radeon/rs690.c | 3 ++-
> drivers/gpu/drm/radeon/rv515.c | 2 +-
> drivers/gpu/drm/radeon/rv6xx_dpm.c | 2 +-
> drivers/gpu/drm/radeon/si_dpm.c | 6 +++---
> 14 files changed, 22 insertions(+), 20 deletions(-)
>
> --
> 2.26.0.106.g9fadedd
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://nam11.safelinks.protection.outlook.com/?url="">
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
