> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Monday, 20 April 2020 23:37 > > On Mon, Apr 13, 2020 at 04:35:53PM +0300, Hadar Gat wrote: > > Both of_platform.h and of_device.h were included each other. > > In of_device.h, removed unneeded #include to of_platform.h and added > > include to of_platform.h in the files that needs it. > > Guess we forgot about that temporary comment! > > Both of these headers have a lot of things we don't want 'normal' > drivers calling. The most common thing needed from of_device.h is > of_match_device/of_device_get_match_data. A good number are only for > ibmebus. Maybe the header should be split or the former just moved to of.h. > > For of_platform.h, it seems we have a bunch of unneeded includes: > > $ git grep 'of_platform\.h' drivers/ | wc > 560 1120 36049 > $ git grep -E 'of_(platform_(pop|def)|find_device)' drivers/ | wc > 248 1215 20630 > > Would nice to drop those (or switch to of_device.h?) too. > > Be sure to build on Sparc. It's the oddball. Hi Rob and thanks for your inputs. Unfortunately I cannot continue to work on this patch at the moment since it is not as small as I expected and I have limited resources for that. So anyone can take it and continue from here. Thanks, Hadar > > Signed-off-by: Hadar Gat <hadar.gat@xxxxxxx> > > --- > > drivers/base/platform.c | 1 + > > drivers/bus/vexpress-config.c | 1 + > > drivers/dma/at_hdmac.c | 1 + > > drivers/dma/stm32-dmamux.c | 1 + > > drivers/dma/ti/dma-crossbar.c | 1 + > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + > > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > > drivers/gpu/drm/msm/msm_drv.c | 1 + > > drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 + > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 + > > drivers/iio/adc/stm32-adc-core.c | 1 + > > drivers/iio/adc/stm32-dfsdm-adc.c | 1 + > > drivers/iio/adc/stm32-dfsdm-core.c | 1 + > > drivers/iommu/tegra-smmu.c | 1 + > > drivers/memory/atmel-ebi.c | 1 + > > drivers/mfd/palmas.c | 1 + > > drivers/mfd/ssbi.c | 1 + > > drivers/mtd/nand/raw/omap2.c | 1 + > > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 + > > drivers/net/ethernet/ti/cpsw.c | 1 + > > drivers/phy/tegra/xusb.c | 1 + > > drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 + > > drivers/soc/samsung/exynos-pmu.c | 1 + > > drivers/soc/sunxi/sunxi_sram.c | 1 + > > include/linux/of_device.h | 2 -- > > lib/genalloc.c | 1 + > > 26 files changed, 25 insertions(+), 2 deletions(-) _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
