Hi, Jitao: Please fixup these checkpatch warnings. WARNING: Missing commit description - Add an appropriate one WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause) #71: FILE: Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:1: +# SPDX-License-Identifier: GPL-2.0 Regards, Chun-Kuang. Jitao Shi <jitao.shi@xxxxxxxxxxxx> 於 2020年4月15日 週三 上午9:13寫道: > > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx> > --- > .../bindings/display/mediatek/mediatek,dpi.txt | 42 ---------- > .../bindings/display/mediatek/mediatek,dpi.yaml | 97 ++++++++++++++++++++++ > 2 files changed, 97 insertions(+), 42 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > deleted file mode 100644 > index 77def4456706..000000000000 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > +++ /dev/null > @@ -1,42 +0,0 @@ > -Mediatek DPI Device > -=================== > - > -The Mediatek DPI function block is a sink of the display subsystem and > -provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel > -output bus. > - > -Required properties: > -- compatible: "mediatek,<chip>-dpi" > - the supported chips are mt2701 , mt8173 and mt8183. > -- reg: Physical base address and length of the controller's registers > -- interrupts: The interrupt signal from the function block. > -- clocks: device clocks > - See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > -- clock-names: must contain "pixel", "engine", and "pll" > -- port: Output port node with endpoint definitions as described in > - Documentation/devicetree/bindings/graph.txt. This port should be connected > - to the input port of an attached HDMI or LVDS encoder chip. > - > -Optional properties: > -- pinctrl-names: Contain "default" and "sleep". > - > -Example: > - > -dpi0: dpi@1401d000 { > - compatible = "mediatek,mt8173-dpi"; > - reg = <0 0x1401d000 0 0x1000>; > - interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; > - clocks = <&mmsys CLK_MM_DPI_PIXEL>, > - <&mmsys CLK_MM_DPI_ENGINE>, > - <&apmixedsys CLK_APMIXED_TVDPLL>; > - clock-names = "pixel", "engine", "pll"; > - pinctrl-names = "default", "sleep"; > - pinctrl-0 = <&dpi_pin_func>; > - pinctrl-1 = <&dpi_pin_idle>; > - > - port { > - dpi0_out: endpoint { > - remote-endpoint = <&hdmi0_in>; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > new file mode 100644 > index 000000000000..2c2d6a71cb8b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: mediatek DPI Controller Device Tree Bindings > + > +maintainers: > + - CK Hu <ck.hu@xxxxxxxxxxxx> > + - Jitao shi <jitao.shi@xxxxxxxxxxxx> > + > +description: | > + The Mediatek DPI function block is a sink of the display subsystem and > + provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel > + output bus. > + > +properties: > + compatible: > + enum: > + - mediatek,mt2701-dpi > + - mediatek,mt8173-dpi > + - mediatek,mt8183-dpi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Pixel Clock > + - description: Engine Clock > + - description: DPI PLL > + > + clock-names: > + items: > + - const: pixel > + - const: engine > + - const: pll > + > + pinctrl-0: true > + pinctrl-1: true > + > + pinctrl-names: > + items: > + - const: default > + - const: sleep > + > + port: > + type: object > + description: > + Output port node with endpoint definitions as described in > + Documentation/devicetree/bindings/graph.txt. This port should be connected > + to the input port of an attached HDMI or LVDS encoder chip. > + > + properties: > + endpoint: > + type: object > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + dpi0: dpi@1401d000 { > + compatible = "mediatek,mt8173-dpi"; > + reg = <0 0x1401d000 0 0x1000>; > + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&mmsys CLK_MM_DPI_PIXEL>, > + <&mmsys CLK_MM_DPI_ENGINE>, > + <&apmixedsys CLK_APMIXED_TVDPLL>; > + clock-names = "pixel", "engine", "pll"; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&dpi_pin_func>; > + pinctrl-1 = <&dpi_pin_idle>; > + > + port { > + dpi0_out: endpoint { > + remote-endpoint = <&hdmi0_in>; > + }; > + }; > + }; > + > +... > -- > 2.12.5 > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel