On 20/04/2020 19:01, Daniel Thompson wrote:
On Fri, Apr 17, 2020 at 02:33:12PM +0300, Tomi Valkeinen wrote:
led_bl_parse_levels() is rather difficult to follow. Rewrite it with a
more obvious code flow.
... that introduces new behaviour.
There's a couple of new behaviours here but the one that particular
attracted my attention is the disregarding the "default-brightness-level" if
there is no table. That looks like a bug to me.
I think the previous behavior was a (minor) bug: how can there be default brightness level if there
are no brightness levels? The led-backlight.txt is a bit lacking (another thing to improve...) but
led-backlight mimics pwm-backlight, and pwm-backlight.txt says
default-brightness-level: The default brightness level (index into the array defined by the
"brightness-levels" property)
But I agree, it's a change, so good to mention.
Please can you add any intended changes of behaviour in the patch
header?
Ok.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
