On Fri, Apr 17, 2020 at 3:27 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Thu, Apr 9, 2020 at 3:39 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > Since the VExpress setup in pl111_vexpress.c is now just a single > > function call, let's move it into pl111_versatile.c and we can further > > simplify pl111_versatile_init() by moving the other pieces for VExpress > > into pl111_vexpress_clcd_init(). > > > > Cc: Eric Anholt <eric@xxxxxxxxxx> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > Yeah that's much nicer, the other boards get a copy of the > Vexpress code but it's so little so it doesn't matter and besides > the Vexpress already had copies of the other boards init code. It shouldn't change. The compiler should be smart enough to drop all the code when IS_ENABLED(CONFIG_ARCH_VEXPRESS) is false. > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Thanks. Rob _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel