On Tue, Apr 14, 2020 at 12:38:16PM +0300, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Tue, Apr 14, 2020 at 10:47:27AM +0200, Sam Ravnborg wrote: > > Make the connector creation optional to enable usage of the > > tc358764 bridge with the DRM bridge connector helper. > > > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > > Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx> > > Cc: Jonas Karlman <jonas@xxxxxxxxx> > > Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxx> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Thanks. I will wait a few days for more feedback before applying. > Thank you for the conversion. "Just a few" more bridge drivers to go, > and then there will be no more excuse not to use the DRM bridge > connector helper :-) A quick grep for ATTACH and drm_bridge_attach_flags gave me following list: adv7511 ongoing, Laurent analogix/analogix-anx6345 todo analogix/analogix-anx78xx todo analogix/analogix_dp_core todo cdns-dsi done? display-connector.c done lvds-codec done? megachips-stdpxxxx-ge-b850v3-fw todo nwl-dsi (ongoing), Guido nxp-ptn3460 todo panel.c done parade-ps8622 todo parade-ps8640 done? sii902x todo sil-sii8620 done? simple-bridge ongoing, Laurent synopsys/dw-hdmi todo synopsys/dw-mipi-dsi done? tc358764 ongoing, Sam tc358767 todo tc358768 done? thc63lvd1024 done? ti-sn65dsi86 todo ti-tfp410 done ti-tpd12s015 todo 3 done 7 done? 4 ongoing 11 todo Maybe a little simplistic - but gives some kind of overview. Drivers marked with "Done?" do not have any hits for ATTACH, dunno if they need more attantion. I will try to take a look at a few of the trivial conversions later this week. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel