On 06/04/2020 16:44, Thomas Zimmermann wrote: > Generic fbdev support is a DRM client. Set it up after fully registering > the new DRM device. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> Acked-by: Jyri Sarha <jsarha@xxxxxx> However, this change hardly makes any difference, as the only place where "is_registere"'s value is checked is in tilcdc_fini() which is also called to cleanup the resources if tilcdc_init() fails. Best regards, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 78c1877d13a83..a5e9ee4c7fbf4 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -390,10 +390,9 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) > ret = drm_dev_register(ddev, 0); > if (ret) > goto init_failed; > + priv->is_registered = true; > > drm_fbdev_generic_setup(ddev, bpp); > - > - priv->is_registered = true; > return 0; > > init_failed: > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
