Re: [PATCH] drm/prime: fix extracting of the DMA addresses from a scatterlist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 27, 2020 at 6:25 AM Shane Francis <bigbeeshane@xxxxxxxxx> wrote:
>
> Hello Marek,
>
> On Fri, Mar 27, 2020 at 9:00 AM Marek Szyprowski
> <m.szyprowski@xxxxxxxxxxx> wrote:
> > > I have tested the above patch against my original issues with amdgpu
> > > and radeon drivers and everything is still working as expected.
> > >
> > > Sorry I missed this in my original patches.
> >
> > No problem. Thanks for testing!
> >
> > Best regards
> > --
> > Marek Szyprowski, PhD
> > Samsung R&D Institute Poland
> >
> Just a thought.
>
> Would it be worth adding some comments to the code to explain why this
> is needed, reading
> the thread around my original patches and the DMA-API documentation it
> is not instantly
> clear why you would be mapping the pages in this way.
>
> Would probably prevent someone in the future making the same mistake I
> did while updating
> this code.

With a comment similar to the commit messaged added to this function,
this patch is:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

Thanks!

Alex
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux