On Tue, Mar 17, 2020 at 03:13:29PM -0700, Joe Perches wrote: > On Tue, 2020-03-17 at 17:48 +0100, Daniel Vetter wrote: > > On Thu, Mar 12, 2020 at 12:17:12PM -0700, Joe Perches wrote: > > > Convert /* fallthrough */ style comments to fallthrough; > > > > > > Convert the various uses of fallthrough comments to fallthrough; > > > > > > Done via script > > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@xxxxxxxxxxx/ > > > > > > And by hand: > > > > > > This file has a fallthrough comment outside of an #ifdef block > > > that causes gcc to emit a warning if converted in-place. > > > > > > So move the new fallthrough; inside the containing #ifdef/#endif too. > > > > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > > > > Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > > I'm assuming this all lands through a special pull? Or should I apply > > this? > > Hi Daniel. > > I think you should apply this. > > The idea here is to allow a scripted conversion at some > point and this patch is necessary to avoid new compiler > warnings after running the script. Ok, put into the queue but missed the 5.7 feature freeze for drm so 5.8 probably. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
