On Di, 2020-03-10 at 16:31 +0300, Wambui Karuga wrote: > Since commit 987d65d01356 (drm: debugfs: make > drm_debugfs_create_files() never fail), drm_debugfs_create_files() never > fails and only returns 0. Therefore, remove the unnecessary check of its > return value and error handling in etnaviv_debugfs_init() and have the > function return 0 directly. > > v2: have etnaviv_debugfs_init() return 0 instead of void to ensure > individual compilation and avoid build breakage. > > References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html > Signed-off-by: Wambui Karuga <wambui.karugax@xxxxxxxxx> Acked-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > index 6b43c1c94e8f..a65d30a48a9d 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > @@ -233,19 +233,11 @@ static struct drm_info_list etnaviv_debugfs_list[] = { > > static int etnaviv_debugfs_init(struct drm_minor *minor) > { > - struct drm_device *dev = minor->dev; > - int ret; > - > - ret = drm_debugfs_create_files(etnaviv_debugfs_list, > - ARRAY_SIZE(etnaviv_debugfs_list), > - minor->debugfs_root, minor); > + drm_debugfs_create_files(etnaviv_debugfs_list, > + ARRAY_SIZE(etnaviv_debugfs_list), > + minor->debugfs_root, minor); > > - if (ret) { > - dev_err(dev->dev, "could not install etnaviv_debugfs_list\n"); > - return ret; > - } > - > - return ret; > + return 0; > } > #endif > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
