Hi Nikolaus,
Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller
<hns@xxxxxxxxxxxxx> a écrit :
From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
Based on .txt binding from Zubair Lutfullah Kakakhel
Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>
Cc: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>
Cc: devicetree@xxxxxxxxxxxxxxx
---
.../bindings/display/ingenic-jz4780-hdmi.yaml | 83
+++++++++++++++++++
1 file changed, 83 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
diff --git
a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
new file mode 100644
index 000000000000..9b71c427bd69
--- /dev/null
+++
b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bindings for Ingenic JZ4780 HDMI Transmitter
+
+maintainers:
+ - Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>
+ - H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
Did Zubair write this glue driver? He's been MIA for a while, doesn't
work at ImgTec anymore, and this email doesn't work.
+
+description: |
+ The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys
DesignWare HDMI 1.4
+ TX controller IP with accompanying PHY IP.
+
+allOf:
+ - $ref: panel/panel-common.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: ingenic,jz4780-hdmi
+
+ reg:
+ maxItems: 1
+ description: the address & size of the LCD controller registers
Remove the description here,
+
+ reg-io-width:
+ const: 4
+
+ interrupts:
+ maxItems: 1
+ description: Specifies the interrupt provided by parent
and here.
The rule is that if there is only one "reg", "interrupts" or "clocks"
entry then a description is not needed as it's pretty obvious what it's
for.
+
+ clocks:
+ maxItems: 2
+ description: Clock specifiers for isrf and iahb clocks
You need two 'description:' like this:
clocks:
items:
- description: ISRF clock
- description: IAHB clock
Cheers,
-Paul
+
+ clock-names:
+ items:
+ - const: isfr
+ - const: iahb
+
+ ddc-i2c-bus: true
+ ports: true
+
+required:
+ - compatible
+ - clocks
+ - clock-names
+ - ports
+ - reg-io-width
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/jz4780-cgu.h>
+
+ hdmi: hdmi@10180000 {
+ compatible = "ingenic,jz4780-hdmi";
+ reg = <0x10180000 0x8000>;
+ reg-io-width = <4>;
+ ddc-i2c-bus = <&i2c4>;
+ interrupt-parent = <&intc>;
+ interrupts = <3>;
+ clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>;
+ clock-names = "isfr", "iahb";
+
+ ports {
+ hdmi_in: port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ hdmi_in_lcd: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&jz4780_out_hdmi>;
+ };
+ };
+ };
+ };
+
+...
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
