Hi Pankaj, Thank you for the patch. You can squash this with the patch that introduced the issue in the same series. Otherwise we will be left with a compilation breakage in the history, which could be annoying when bisecting issues. On Mon, Mar 02, 2020 at 06:26:47PM +0530, Pankaj Bharadiya wrote: > drm_device pointer is not getting used in tc358764_detach() anymore, > hence remove it. > > This fixes below warning. > > drivers/gpu/drm/bridge/tc358764.c: In function ‘tc358764_detach’: > drivers/gpu/drm/bridge/tc358764.c:386:21: warning: unused variable ‘drm’ [-Wunused-variable] > struct drm_device *drm = bridge->dev; > ^~~ > > Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@xxxxxxxxx> > --- > drivers/gpu/drm/bridge/tc358764.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c > index 530342dd4a34..5ac1430fab04 100644 > --- a/drivers/gpu/drm/bridge/tc358764.c > +++ b/drivers/gpu/drm/bridge/tc358764.c > @@ -383,7 +383,6 @@ static int tc358764_attach(struct drm_bridge *bridge, > static void tc358764_detach(struct drm_bridge *bridge) > { > struct tc358764 *ctx = bridge_to_tc358764(bridge); > - struct drm_device *drm = bridge->dev; > > drm_connector_unregister(&ctx->connector); > drm_panel_detach(ctx->panel); -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel