On 18/02/2020 17:55, Wambui Karuga wrote:
> Remove the check and error handling of the return value of
> drm_debugfs_create_files as it is not needed in tilcdc_debugfs_init.
> Also remove local variables that are not used after the changes.
>
> Signed-off-by: Wambui Karuga <wambui.karugax@xxxxxxxxx>
Reviewed-by: Jyri Sarha <jsarha@xxxxxx>
Tested-by: Jyri Sarha <jsarha@xxxxxx>
I'll merge this to drm-misc-next tomorrow.
Thank you for the patch,
Jyri
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 0791a0200cc3..3f7071eb9c78 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -480,24 +480,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = {
>
> static int tilcdc_debugfs_init(struct drm_minor *minor)
> {
> - struct drm_device *dev = minor->dev;
> struct tilcdc_module *mod;
> - int ret;
>
> - ret = drm_debugfs_create_files(tilcdc_debugfs_list,
> - ARRAY_SIZE(tilcdc_debugfs_list),
> - minor->debugfs_root, minor);
> + drm_debugfs_create_files(tilcdc_debugfs_list,
> + ARRAY_SIZE(tilcdc_debugfs_list),
> + minor->debugfs_root, minor);
>
> list_for_each_entry(mod, &module_list, list)
> if (mod->funcs->debugfs_init)
> mod->funcs->debugfs_init(mod, minor);
>
> - if (ret) {
> - dev_err(dev->dev, "could not install tilcdc_debugfs_list\n");
> - return ret;
> - }
> -
> - return ret;
> + return 0;
> }
> #endif
>
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
