Re: [PATCH/RFC 3/3] drm: rcar_du: Constify drm_driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Emil,

On Mon, Feb 24, 2020 at 03:26:05PM +0000, Emil Velikov wrote:
> Thanks Laurent for sorting this out.

You're welcome. It's been bothering me for some time :-)

> On Sat, 22 Feb 2020 at 17:59, Daniel Vetter <daniel@xxxxxxxx> wrote:
> > On Sat, Feb 22, 2020 at 05:24:30PM +0200, Laurent Pinchart wrote:
> > > The drm_driver structure is never modified, make it const. The improves
> > > security by avoiding writable function pointers.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> >
> > I wonder whether there's some magic somewhere we could do to enlist the
> > cocci army to create the constify patches for us ...
> >
> IIRC some drivers still manually thinker with their struct drm_driver ;-)
> 
> That said, the series looks good:
> Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>

Does this apply to the whole series, or to this patch only ?

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux