On Sat, Feb 22, 2020 at 01:32:40PM +0100, Sam Ravnborg wrote: > Hi Ville. > > Nice patch - and diffstat looks good: > > 63 files changed, 217 insertions(+), 392 deletions(-) > > There is an item in the Documentation/gpu/todo.rst that > describes this. > Could you drop this from todo.rst in this patch too. Yeah, missed the TODO. Looks like there's one for hsync removal as well. > > > diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c > > index bb6528b01cd0..6dca5344c0b3 100644 > > --- a/drivers/gpu/drm/mcde/mcde_dsi.c > > +++ b/drivers/gpu/drm/mcde/mcde_dsi.c > > @@ -538,7 +538,7 @@ static void mcde_dsi_setup_video_mode(struct mcde_dsi *d, > > */ > > /* (ps/s) / (pixels/s) = ps/pixels */ > > pclk = DIV_ROUND_UP_ULL(1000000000000, > > - (mode->vrefresh * mode->htotal * mode->vtotal)); > > + (drm_mode_vrefresh(mode) * mode->htotal * mode->vtotal)); > > dev_dbg(d->dev, "picoseconds between two pixels: %llu\n", > > pclk); > > > > This just caught my eye while browsing the patch. > It looks like a backward way to get the clock. Yep. I'll cook up a patch to switch this to ->clock. > > But patch is fine, it was just a drive-by comment. > > Whole patch is: > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > (with or without removal of todo item added) > > Sam -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
