On Thu, 20 Feb 2020, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > Looks like getting rid of private_flags is going to be pretty > straightforward. I'll post patches for that once this first series > lands. Going all in on crtc state? I suppose migrating away from private_flags could easily start in i915 before that. Seems rather independent. I guess it's __intel_get_crtc_scanline() and: vblank = &crtc->base.dev->vblank[drm_crtc_index(&crtc->base)]; mode = &vblank->hwmode; if (mode->private_flags & I915_MODE_FLAG_GET_SCANLINE_FROM_TIMESTAMP) that gives me the creeps in reviewing all that. There's also [1] adding new uses for private_flags; I think there were issues in getting at the right crtc state on some of those paths, but I forget the exact details. Ideas? BR, Jani. [1] https://patchwork.freedesktop.org/series/69290/ -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
