On Tue, Feb 18, 2020 at 08:00:30PM +0100, Daniel Vetter wrote:
> On Tue, Feb 18, 2020 at 6:28 PM Wambui Karuga <wambui.karugax@xxxxxxxxx> wrote:
> >
> > As drm_debugfs_create_files should return void, remove its use as the
> > return value of arcpgu_debugfs_init and have the latter function
> > return 0 directly.
> >
> > Signed-off-by: Wambui Karuga <wambui.karugax@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/arc/arcpgu_drv.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
> > index d6a6692db0ac..660b25f9588e 100644
> > --- a/drivers/gpu/drm/arc/arcpgu_drv.c
> > +++ b/drivers/gpu/drm/arc/arcpgu_drv.c
> > @@ -139,8 +139,10 @@ static struct drm_info_list arcpgu_debugfs_list[] = {
> >
> > static int arcpgu_debugfs_init(struct drm_minor *minor)
> > {
> > - return drm_debugfs_create_files(arcpgu_debugfs_list,
> > - ARRAY_SIZE(arcpgu_debugfs_list), minor->debugfs_root, minor);
> > + drm_debugfs_create_files(arcpgu_debugfs_list,
> > + ARRAY_SIZE(arcpgu_debugfs_list),
> > + minor->debugfs_root, minor);
> > + return 0;
>
> For cases like these I think we should go a step further and also
> remove the return value from the driver wrapper. And that all the way
> up until there's something that actually needs to return a value for
> some other reason than debugfs.
This ofc applies to almost all the driver patches for this series, most
can be cleaned up quite a bit more.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
