Re: [PATCH 4/8] drm/nouveau: don't use ttm bo->offset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/17/20 4:57 PM, Alex Deucher wrote:
On Mon, Feb 17, 2020 at 10:02 AM Nirmoy Das <nirmoy.aiemd@xxxxxxxxx> wrote:
Store ttm bo->offset in struct nouveau_bo instead.

Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>
Christian König <christian.koenig@xxxxxxx>
Missing Acked or Reviewed prefix for Christian.

:facepalm: Thanks Alex.

Nirmoy


Alex

---
  drivers/gpu/drm/nouveau/dispnv04/crtc.c     |  6 +++---
  drivers/gpu/drm/nouveau/dispnv04/disp.c     |  2 +-
  drivers/gpu/drm/nouveau/dispnv04/overlay.c  |  6 +++---
  drivers/gpu/drm/nouveau/dispnv50/base507c.c |  2 +-
  drivers/gpu/drm/nouveau/dispnv50/core507d.c |  2 +-
  drivers/gpu/drm/nouveau/dispnv50/ovly507e.c |  2 +-
  drivers/gpu/drm/nouveau/dispnv50/wndw.c     |  2 +-
  drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |  2 +-
  drivers/gpu/drm/nouveau/nouveau_abi16.c     |  8 ++++----
  drivers/gpu/drm/nouveau/nouveau_bo.c        |  1 +
  drivers/gpu/drm/nouveau/nouveau_bo.h        |  3 +++
  drivers/gpu/drm/nouveau/nouveau_chan.c      |  2 +-
  drivers/gpu/drm/nouveau/nouveau_dmem.c      |  2 +-
  drivers/gpu/drm/nouveau/nouveau_fbcon.c     |  2 +-
  drivers/gpu/drm/nouveau/nouveau_gem.c       | 10 +++++-----
  15 files changed, 28 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
index 1f08de4241e0..d06a93f2b38a 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
@@ -845,7 +845,7 @@ nv04_crtc_do_mode_set_base(struct drm_crtc *crtc,
                 fb = nouveau_framebuffer(crtc->primary->fb);
         }

-       nv_crtc->fb.offset = fb->nvbo->bo.offset;
+       nv_crtc->fb.offset = fb->nvbo->offset;

         if (nv_crtc->lut.depth != drm_fb->format->depth) {
                 nv_crtc->lut.depth = drm_fb->format->depth;
@@ -1013,7 +1013,7 @@ nv04_crtc_cursor_set(struct drm_crtc *crtc, struct drm_file *file_priv,
                 nv04_cursor_upload(dev, cursor, nv_crtc->cursor.nvbo);

         nouveau_bo_unmap(cursor);
-       nv_crtc->cursor.offset = nv_crtc->cursor.nvbo->bo.offset;
+       nv_crtc->cursor.offset = nv_crtc->cursor.nvbo->offset;
         nv_crtc->cursor.set_offset(nv_crtc, nv_crtc->cursor.offset);
         nv_crtc->cursor.show(nv_crtc, true);
  out:
@@ -1191,7 +1191,7 @@ nv04_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb,
         /* Initialize a page flip struct */
         *s = (struct nv04_page_flip_state)
                 { { }, event, crtc, fb->format->cpp[0] * 8, fb->pitches[0],
-                 new_bo->bo.offset };
+                 new_bo->offset };

         /* Keep vblanks on during flip, for the target crtc of this flip */
         drm_crtc_vblank_get(crtc);
diff --git a/drivers/gpu/drm/nouveau/dispnv04/disp.c b/drivers/gpu/drm/nouveau/dispnv04/disp.c
index 44ee82d0c9b6..89a4ddfcc55f 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/disp.c
@@ -151,7 +151,7 @@ nv04_display_init(struct drm_device *dev, bool resume, bool runtime)
                         continue;

                 if (nv_crtc->cursor.set_offset)
-                       nv_crtc->cursor.set_offset(nv_crtc, nv_crtc->cursor.nvbo->bo.offset);
+                       nv_crtc->cursor.set_offset(nv_crtc, nv_crtc->cursor.nvbo->offset);
                 nv_crtc->cursor.set_pos(nv_crtc, nv_crtc->cursor_saved_x,
                                                  nv_crtc->cursor_saved_y);
         }
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index a3a0a73ae8ab..9529bd9053e7 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -150,7 +150,7 @@ nv10_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
         nvif_mask(dev, NV_PCRTC_ENGINE_CTRL + soff2, NV_CRTC_FSEL_OVERLAY, 0);

         nvif_wr32(dev, NV_PVIDEO_BASE(flip), 0);
-       nvif_wr32(dev, NV_PVIDEO_OFFSET_BUFF(flip), nv_fb->nvbo->bo.offset);
+       nvif_wr32(dev, NV_PVIDEO_OFFSET_BUFF(flip), nv_fb->nvbo->offset);
         nvif_wr32(dev, NV_PVIDEO_SIZE_IN(flip), src_h << 16 | src_w);
         nvif_wr32(dev, NV_PVIDEO_POINT_IN(flip), src_y << 16 | src_x);
         nvif_wr32(dev, NV_PVIDEO_DS_DX(flip), (src_w << 20) / crtc_w);
@@ -172,7 +172,7 @@ nv10_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
         if (format & NV_PVIDEO_FORMAT_PLANAR) {
                 nvif_wr32(dev, NV_PVIDEO_UVPLANE_BASE(flip), 0);
                 nvif_wr32(dev, NV_PVIDEO_UVPLANE_OFFSET_BUFF(flip),
-                       nv_fb->nvbo->bo.offset + fb->offsets[1]);
+                       nv_fb->nvbo->offset + fb->offsets[1]);
         }
         nvif_wr32(dev, NV_PVIDEO_FORMAT(flip), format | fb->pitches[0]);
         nvif_wr32(dev, NV_PVIDEO_STOP, 0);
@@ -396,7 +396,7 @@ nv04_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,

         for (i = 0; i < 2; i++) {
                 nvif_wr32(dev, NV_PVIDEO_BUFF0_START_ADDRESS + 4 * i,
-                         nv_fb->nvbo->bo.offset);
+                         nv_fb->nvbo->offset);
                 nvif_wr32(dev, NV_PVIDEO_BUFF0_PITCH_LENGTH + 4 * i,
                           fb->pitches[0]);
                 nvif_wr32(dev, NV_PVIDEO_BUFF0_OFFSET + 4 * i, 0);
diff --git a/drivers/gpu/drm/nouveau/dispnv50/base507c.c b/drivers/gpu/drm/nouveau/dispnv50/base507c.c
index 00a85f1e1a4a..67829f04b2c7 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/base507c.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/base507c.c
@@ -274,7 +274,7 @@ base507c_new_(const struct nv50_wndw_func *func, const u32 *format,

         ret = nv50_dmac_create(&drm->client.device, &disp->disp->object,
                                &oclass, head, &args, sizeof(args),
-                              disp->sync->bo.offset, &wndw->wndw);
+                              disp->sync->offset, &wndw->wndw);
         if (ret) {
                 NV_ERROR(drm, "base%04x allocation failed: %d\n", oclass, ret);
                 return ret;
diff --git a/drivers/gpu/drm/nouveau/dispnv50/core507d.c b/drivers/gpu/drm/nouveau/dispnv50/core507d.c
index e7fcfa6e6467..793dcb2ea196 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/core507d.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/core507d.c
@@ -99,7 +99,7 @@ core507d_new_(const struct nv50_core_func *func, struct nouveau_drm *drm,

         ret = nv50_dmac_create(&drm->client.device, &disp->disp->object,
                                &oclass, 0, &args, sizeof(args),
-                              disp->sync->bo.offset, &core->chan);
+                              disp->sync->offset, &core->chan);
         if (ret) {
                 NV_ERROR(drm, "core%04x allocation failed: %d\n", oclass, ret);
                 return ret;
diff --git a/drivers/gpu/drm/nouveau/dispnv50/ovly507e.c b/drivers/gpu/drm/nouveau/dispnv50/ovly507e.c
index 8ccd96113bad..4cce1078140a 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/ovly507e.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/ovly507e.c
@@ -186,7 +186,7 @@ ovly507e_new_(const struct nv50_wndw_func *func, const u32 *format,

         ret = nv50_dmac_create(&drm->client.device, &disp->disp->object,
                                &oclass, 0, &args, sizeof(args),
-                              disp->sync->bo.offset, &wndw->wndw);
+                              disp->sync->offset, &wndw->wndw);
         if (ret) {
                 NV_ERROR(drm, "ovly%04x allocation failed: %d\n", oclass, ret);
                 return ret;
diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/gpu/drm/nouveau/dispnv50/wndw.c
index 890315291b01..e90ffa4a5230 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/wndw.c
@@ -509,7 +509,7 @@ nv50_wndw_prepare_fb(struct drm_plane *plane, struct drm_plane_state *state)
         }

         asyw->state.fence = dma_resv_get_excl_rcu(fb->nvbo->bo.base.resv);
-       asyw->image.offset[0] = fb->nvbo->bo.offset;
+       asyw->image.offset[0] = fb->nvbo->offset;

         if (wndw->func->prepare) {
                 asyh = nv50_head_atom_get(asyw->state.state, asyw->state.crtc);
diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c b/drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c
index b92dc3461bbd..bb84e4d54a33 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c
@@ -298,7 +298,7 @@ wndwc37e_new_(const struct nv50_wndw_func *func, struct nouveau_drm *drm,

         ret = nv50_dmac_create(&drm->client.device, &disp->disp->object,
                                &oclass, 0, &args, sizeof(args),
-                              disp->sync->bo.offset, &wndw->wndw);
+                              disp->sync->offset, &wndw->wndw);
         if (ret) {
                 NV_ERROR(drm, "qndw%04x allocation failed: %d\n", oclass, ret);
                 return ret;
diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c
index e2bae1424502..c32a8ca67f82 100644
--- a/drivers/gpu/drm/nouveau/nouveau_abi16.c
+++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c
@@ -558,13 +558,13 @@ nouveau_abi16_ioctl_notifierobj_alloc(ABI16_IOCTL_ARGS)
         if (drm->agp.bridge) {
                 args.target = NV_DMA_V0_TARGET_AGP;
                 args.access = NV_DMA_V0_ACCESS_RDWR;
-               args.start += drm->agp.base + chan->ntfy->bo.offset;
-               args.limit += drm->agp.base + chan->ntfy->bo.offset;
+               args.start += drm->agp.base + chan->ntfy->offset;
+               args.limit += drm->agp.base + chan->ntfy->offset;
         } else {
                 args.target = NV_DMA_V0_TARGET_VM;
                 args.access = NV_DMA_V0_ACCESS_RDWR;
-               args.start += chan->ntfy->bo.offset;
-               args.limit += chan->ntfy->bo.offset;
+               args.start += chan->ntfy->offset;
+               args.limit += chan->ntfy->offset;
         }

         client->route = NVDRM_OBJECT_ABI16;
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 2b4b21b02e40..ebf31035e1e3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1311,6 +1311,7 @@ nouveau_bo_move_ntfy(struct ttm_buffer_object *bo, bool evict,
                 list_for_each_entry(vma, &nvbo->vma_list, head) {
                         nouveau_vma_map(vma, mem);
                 }
+               nvbo->offset = (new_reg->start << PAGE_SHIFT);
         } else {
                 list_for_each_entry(vma, &nvbo->vma_list, head) {
                         WARN_ON(ttm_bo_wait(bo, false, false));
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.h b/drivers/gpu/drm/nouveau/nouveau_bo.h
index 38f9d8350963..e944b4aa5547 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.h
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.h
@@ -24,6 +24,9 @@ struct nouveau_bo {
         int pbbo_index;
         bool validate_mapped;

+       /* GPU address space is independent of CPU word size */
+       uint64_t offset;
+
         struct list_head vma_list;

         unsigned contig:1;
diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c b/drivers/gpu/drm/nouveau/nouveau_chan.c
index d9381a053169..3d71dfcb2fde 100644
--- a/drivers/gpu/drm/nouveau/nouveau_chan.c
+++ b/drivers/gpu/drm/nouveau/nouveau_chan.c
@@ -162,7 +162,7 @@ nouveau_channel_prep(struct nouveau_drm *drm, struct nvif_device *device,
          * pushbuf lives in, this is because the GEM code requires that
          * we be able to call out to other (indirect) push buffers
          */
-       chan->push.addr = chan->push.buffer->bo.offset;
+       chan->push.addr = chan->push.buffer->offset;

         if (device->info.family >= NV_DEVICE_INFO_V0_TESLA) {
                 ret = nouveau_vma_new(chan->push.buffer, chan->vmm,
diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
index 0ad5d87b5a8e..475ed53b99f1 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
@@ -89,7 +89,7 @@ static unsigned long nouveau_dmem_page_addr(struct page *page)
         struct nouveau_dmem_chunk *chunk = page->zone_device_data;
         unsigned long idx = page_to_pfn(page) - chunk->pfn_first;

-       return (idx << PAGE_SHIFT) + chunk->bo->bo.offset;
+       return (idx << PAGE_SHIFT) + chunk->bo->offset;
  }

  static void nouveau_dmem_page_free(struct page *page)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 0c5cdda3c336..508b118c0953 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -393,7 +393,7 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,

         /* To allow resizeing without swapping buffers */
         NV_INFO(drm, "allocated %dx%d fb: 0x%llx, bo %p\n",
-               fb->base.width, fb->base.height, fb->nvbo->bo.offset, nvbo);
+               fb->base.width, fb->base.height, fb->nvbo->offset, nvbo);

         vga_switcheroo_client_fb_set(dev->pdev, info);
         return 0;
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index f5ece1f94973..cadff37eade8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -232,7 +232,7 @@ nouveau_gem_info(struct drm_file *file_priv, struct drm_gem_object *gem,
                 rep->domain = NOUVEAU_GEM_DOMAIN_GART;
         else
                 rep->domain = NOUVEAU_GEM_DOMAIN_VRAM;
-       rep->offset = nvbo->bo.offset;
+       rep->offset = nvbo->offset;
         if (vmm->vmm.object.oclass >= NVIF_CLASS_VMM_NV50) {
                 vma = nouveau_vma_find(nvbo, vmm);
                 if (!vma)
@@ -516,7 +516,7 @@ validate_list(struct nouveau_channel *chan, struct nouveau_cli *cli,
                 }

                 if (drm->client.device.info.family < NV_DEVICE_INFO_V0_TESLA) {
-                       if (nvbo->bo.offset == b->presumed.offset &&
+                       if (nvbo->offset == b->presumed.offset &&
                             ((nvbo->bo.mem.mem_type == TTM_PL_VRAM &&
                               b->presumed.domain & NOUVEAU_GEM_DOMAIN_VRAM) ||
                              (nvbo->bo.mem.mem_type == TTM_PL_TT &&
@@ -527,7 +527,7 @@ validate_list(struct nouveau_channel *chan, struct nouveau_cli *cli,
                                 b->presumed.domain = NOUVEAU_GEM_DOMAIN_GART;
                         else
                                 b->presumed.domain = NOUVEAU_GEM_DOMAIN_VRAM;
-                       b->presumed.offset = nvbo->bo.offset;
+                       b->presumed.offset = nvbo->offset;
                         b->presumed.valid = 0;
                         relocs++;
                 }
@@ -805,7 +805,7 @@ nouveau_gem_ioctl_pushbuf(struct drm_device *dev, void *data,
                         struct nouveau_bo *nvbo = (void *)(unsigned long)
                                 bo[push[i].bo_index].user_priv;

-                       OUT_RING(chan, (nvbo->bo.offset + push[i].offset) | 2);
+                       OUT_RING(chan, (nvbo->offset + push[i].offset) | 2);
                         OUT_RING(chan, 0);
                 }
         } else {
@@ -840,7 +840,7 @@ nouveau_gem_ioctl_pushbuf(struct drm_device *dev, void *data,
                         }

                         OUT_RING(chan, 0x20000000 |
-                                     (nvbo->bo.offset + push[i].offset));
+                                     (nvbo->offset + push[i].offset));
                         OUT_RING(chan, 0);
                         for (j = 0; j < NOUVEAU_DMA_SKIPS; j++)
                                 OUT_RING(chan, 0);
--
2.25.0

_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cnirmoy.das%40amd.com%7C61fe524a09c64a10891d08d7b3c221a8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637175518684441041&amp;sdata=oHp63aoK9vbCtKA89jXhIO%2FRyzj9uNkLl2NTPk5waig%3D&amp;reserved=0
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux