On Wed, Feb 12, 2020 at 04:29:48PM +0100, Stephan Gerhold wrote: > Hi Maxime, > > On Fri, Jan 17, 2020 at 07:51:00PM +0100, Maxime Ripard wrote: > > On Fri, Jan 17, 2020 at 04:34:27PM +0100, Stephan Gerhold wrote: > > > At the moment, video mode parameters like video=540x960,reflect_x, > > > (without rotation set) are not taken into account when applying the > > > mode in drm_client_modeset.c. > > > > > > One of the reasons for this is that the calculation that > > > combines the panel_orientation with cmdline->rotation_reflection > > > does not handle the case when cmdline->rotation_reflection does > > > not have any rotation set. > > > (i.e. cmdline->rotation_reflection & DRM_MODE_ROTATE_MASK == 0) > > > > > > However, we really should not generate such a value in the first place. > > > Rotation values should have exactly one rotation angle set > > > (DRM_MODE_ROTATE_0 for "no rotation"). > > > > > > This patch set changes the command line parser to make sure that we generate > > > only valid rotation values (defaulting to DRM_MODE_ROTATE_0). > > > > > > Finally it allows DRM_MODE_ROTATE_0 when applying the rotation from > > > the video mode parameters to make parameters without rotation work correctly. > > > > For both, > > Acked-by: Maxime Ripard <mripard@xxxxxxxxxx> > > Can you apply these two patches for me? > This is my second contribution to the DRM subsystem, so I don't have > commit access to drm-misc yet. Applied both, thanks! Maxime
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
