On Tue, Feb 11, 2020 at 3:56 PM Gurchetan Singh <gurchetansingh@xxxxxxxxxxxx> wrote: > > We only want create a new virglrenderer context after the first > 3D ioctl. > > Signed-off-by: Gurchetan Singh <gurchetansingh@xxxxxxxxxxxx> > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 5 +++++ > drivers/gpu/drm/virtio/virtgpu_kms.c | 2 ++ > 3 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h > index edaa7b8224a8..93ce69c0d9be 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_drv.h > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.h > @@ -209,6 +209,7 @@ struct virtio_gpu_device { > > struct virtio_gpu_fpriv { > uint32_t ctx_id; > + atomic_t context_initiated; > }; > /* virtio_ioctl.c */ > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > index f1afabaa3a08..858ee153fb18 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > @@ -44,9 +44,14 @@ void virtio_gpu_create_context(struct drm_device *dev, > if (!vgdev->has_virgl_3d) > return; > > + if (atomic_read(&vfpriv->context_initiated)) > + return; > + > get_task_comm(dbgname, current); > virtio_gpu_cmd_context_create(vgdev, vfpriv->ctx_id, > strlen(dbgname), dbgname); > + > + atomic_inc(&vfpriv->context_initiated); > } This needs to be protected with a lock. ctx_id can probably be generated here as well. > > static int virtio_gpu_map_ioctl(struct drm_device *dev, void *data, > diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c > index e1e1c0821a35..64fe5fcbedfd 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_kms.c > +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c > @@ -270,7 +270,9 @@ int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file) > return id; > } > > + > vfpriv->ctx_id = id; > + atomic_set(&vfpriv->context_initiated, 0); > file->driver_priv = vfpriv; > virtio_gpu_create_context(dev, file); > > -- > 2.25.0.225.g125e21ebc7-goog > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel