On 10.02.2020 09:21, Tomi Valkeinen wrote: > Hi Andrzej, > > On 21/01/2020 11:46, Tomi Valkeinen wrote: >> Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz, >> max 165MHz. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> >> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >> --- >> drivers/gpu/drm/bridge/ti-tfp410.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c >> index 6f6d6d1e60ae..108e8cd7ab68 100644 >> --- a/drivers/gpu/drm/bridge/ti-tfp410.c >> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c >> @@ -167,10 +167,23 @@ static void tfp410_disable(struct drm_bridge *bridge) >> gpiod_set_value_cansleep(dvi->powerdown, 1); >> } >> >> +static enum drm_mode_status tfp410_mode_valid(struct drm_bridge *bridge, >> + const struct drm_display_mode *mode) >> +{ >> + if (mode->clock < 25000) >> + return MODE_CLOCK_LOW; >> + >> + if (mode->clock > 165000) >> + return MODE_CLOCK_HIGH; >> + >> + return MODE_OK; >> +} >> + >> static const struct drm_bridge_funcs tfp410_bridge_funcs = { >> .attach = tfp410_attach, >> .enable = tfp410_enable, >> .disable = tfp410_disable, >> + .mode_valid = tfp410_mode_valid, >> }; >> >> static void tfp410_hpd_work_func(struct work_struct *work) >> > Is this ok to merge? Yes, If I remember you have merge rights. If not, let me know. Andrzej > > Tomi > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel