On Fri, Feb 07, 2020 at 03:16:02PM +0100, Thomas Zimmermann wrote:
> Atomic modesetting doesn't use struct drm_connector_funcs.dpms and
> the set function, drm_helper_connector_dpms(), wouldn't support it
> anyway. So keep the pointer to NULL.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
On both patches:
Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
I just suggested a drm_mode_config_validate() to Ville in his patch
series, which runs in drm_dev_register(). Maybe we could add a check for
that for atomic drivers? It's a bit a game of whack-a-mole otherwise :-)
-Daniel
> ---
> drivers/gpu/drm/udl/udl_connector.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c
> index e9671d38b4a0..0afdfb0d1fe1 100644
> --- a/drivers/gpu/drm/udl/udl_connector.c
> +++ b/drivers/gpu/drm/udl/udl_connector.c
> @@ -109,7 +109,6 @@ static const struct drm_connector_helper_funcs udl_connector_helper_funcs = {
> };
>
> static const struct drm_connector_funcs udl_connector_funcs = {
> - .dpms = drm_helper_connector_dpms,
> .reset = drm_atomic_helper_connector_reset,
> .detect = udl_detect,
> .fill_modes = drm_helper_probe_single_connector_modes,
> --
> 2.25.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
