Re: [PATCH] drm: Add missing newline after comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-02-05 23:50, Joe Perches wrote:
> On Wed, 2020-02-05 at 23:26 +0100, Stefan Agner wrote:
>> Clang prints a warning:
>> drivers/gpu/drm/drm_lock.c:363:6: warning: misleading indentation;
>> statement is not part of the previous 'if' [-Wmisleading-indentation]
>>          */     mutex_lock(&dev->struct_mutex);
>>                 ^
>> drivers/gpu/drm/drm_lock.c:357:2: note: previous statement is here
>>         if (!drm_core_check_feature(dev, DRIVER_LEGACY))
>>         ^
>>
>> Fix this by adding a newline after the multi-line comment.
> 
> Thanks, already in -next

Whoops, sorry for the duplication. Searched for "indentation" which did
not bring that one up.

--
Stefan

> 
> commit 5b99cad6966b92f757863ff9b6688051633fde9a
> Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Date:   Wed Jan 8 08:43:12 2020 +0300
> 
>     gpu/drm: clean up white space in drm_legacy_lock_master_cleanup()
>     
>     We moved this code to a different file and accidentally deleted a
>     newline.
>     
>     Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>     Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
>     Link:
> https://patchwork.freedesktop.org/patch/msgid/20200108054312.yzlj5wmbdktejgob@kili.mountain
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux