Re: [PATCH v3 libdrm 2/2] Add drmModeGetFB2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Juston,

On Thu, 23 Jan 2020 at 00:37, Juston Li <juston.li@xxxxxxxxx> wrote:
> +drm_public void drmModeFreeFB2(drmModeFB2Ptr ptr)
> +{
> +       if (!ptr)
> +               return;
> +
> +       /* we might add more frees later. */
> +       drmFree(ptr);

I do not recognise this comment, and since free(NULL) is defined to be
safe, this entire function can be defined as drmFree(ptr) without the
comment or early return.

I would like this to be changed before merging. After the revision,
this patch is:
Signed-off-by: Daniel Stone <daniels@xxxxxxxxxxxxx>

Cheers,
Daniel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux