Hi Andrzej, Sorry for the delay in reviewing the patches. I am hoping to get through the review early next week if that is OK with you. Best regards, Liviu On Thu, Jan 30, 2020 at 10:08:15AM +0100, Andrzej Pietrasiewicz wrote: > Hi All, > > A gentle reminder. > > Please also see inline: > > W dniu 17.12.2019 o 15:49, Andrzej Pietrasiewicz pisze: > > This series adds AFBC support for Rockchip. It is inspired by: > > > > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/factory-gru-9017.B-chromeos-4.4/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > > > > This is the fifth iteration of the afbc series. Between v3 and v4 a lot of > > rework has been done, the main goal of which was to move all afbc-related > > checks to helpers, so that core does not deal with it. > > > > A new struct drm_afbc_framebuffer is added, which stores afbc-related > > driver-specific data. Because of that, in drivers that wish to > > use this feature, the struct must be allocated directly in the driver > > code rather than inside helpers, so the first portion of the patchset > > does the necessary refactoring. > > > > Then, there are 3 users of afbc: komeda, malidp and, finally, rockchip, > > the latter being the ultimate purpose of this work and the 3 subsequent > > portions of the patchset move komeda and malidp to generic helpers and add > > afbc support to rockchip. > > If changes in komeda and malidp is too much to digest at a time I can > focus on rockchip only. This would amount to patches 1-4 and 33-34. > After all the ultimate purpose of this work and time spent on it > is landing afbc support for rockchip. > > Regards, > > Andrzej -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel