On Sat, 25 Jan 2020, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Quoting Wambui Karuga (2020-01-22 12:57:48) >> This series is a part of the conversion to the new struct drm_device >> based logging macros in drm/i915. >> This series focuses on the drm/i915/gem directory and converts all >> straightforward instances of the printk based logging macros to the new >> macros. > > Overall, I'm not keen on this as it perpetuates the mistake of putting > client debug message in dmesg and now gives them even more an air of > being device driver debug messages. We need a mechanism by which we > report the details of what a client did wrong back to that client > (tracefs + context/client getparam to return an isolated debug fd is my > idea). I don't disagree, but I also don't think this makes things (much) worse in that regard. > >> Wambui Karuga (2): >> drm/i915/gem: initial conversion to new logging macros using >> coccinelle. >> drm/i915/gem: manual conversion to struct drm_device logging macros. > > Still this is a necessary evil for the current situation, > Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Thanks, pushed both. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
