Re: [PATCH v8 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/01/2020 23:02, Jyri Sarha wrote:
This patch adds a new DRM driver for Texas Instruments DSS IPs used on
Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is
a major change to the older DSS IP versions, which are supported by
the omapdrm driver. While on higher level the Keystone DSS resembles
the older DSS versions, the registers are completely different and the
internal pipelines differ a lot.

DSS IP found on K2G is an "ultra-light" version, and has only a single
plane and a single output. The K3 DSS IPs are found on AM65x and J721E
SoCs. AM65x DSS has two video ports, one full video plane, and another
"lite" plane without scaling support. J721E has 4 video ports, 2 video
planes and 2 lite planes. AM65x DSS has also an integrated OLDI (LVDS)
output.

Version history:

v2: - rebased on top of drm-next-2019-11-27
     - sort all include lines in all files
     - remove all include <drm/drmP.h>
     - remove select "select VIDEOMODE_HELPERS"
     - call dispc_vp_setup() later in tidss_crtc_atomic_flush() (there is no
       to call it in new modeset case as it is also called in vp_enable())
     - change probe sequence and drm_device allocation (follow example in
       drm_drv.c)
     - use __maybe_unused instead of #ifdef for pm functions
     - remove "struct drm_fbdev_cma *fbdev;" from driver data
     - check panel connector type before connecting it

v3: no change

v4: no change

v5: - remove fifo underflow irq handling, it is not an error and
       it should be used for debug purposes only
     - memory tuning, prefetch plane fifo up to high-threshold value to
       minimize possibility of underflows.

v6: - Check CTM and gamma support from dispc_features when creating crtc
     - Implement CTM support for k2g and fix k3 CTM implementation
     - Remove gamma property persistence and always write color properties
       in a new modeset

v7: - Fix checkpatch.pl --strict issues
     - Rebase on top of drm-misc-next-2020-01-10

v8: - Remove idle debug prints from dispc_init()
     - Add Reviewed-by: Benoit Parrot <bparrot@xxxxxx>

Co-developed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
Signed-off-by: Jyri Sarha <jsarha@xxxxxx>
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Reviewed-by: Benoit Parrot <bparrot@xxxxxx>

You can add my SoB too:

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux