Hi Benjamin. On Mon, Jan 20, 2020 at 08:11:01AM +0000, Benjamin GAIGNARD wrote: > > On 1/18/20 10:41 AM, Sam Ravnborg wrote: > > Hi Benjamin > > > > On Tue, Jan 14, 2020 at 05:01:35PM +0100, Benjamin Gaignard wrote: > >> Remove old documentation style and use new one to avoid warnings when > >> compiling with W=1 > >> > >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx> > > Thanks for the warning fixes. > > This is legacy stuff that is not even wired into the kernel-doc stuff. > > But that is no excuse for old-style comments. > > There is still quite a few of them in other drm files (drm_context.c, > drm_bufs.c, drm_vm.c, drm_lock.c) > > but I don't know how to fix them. Your advices are welcome. I have no strong opinion on way forward here. But if someone (you?) type the patches and they are even acked, we should not ignore them. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel