On 12/13, Daniel Vetter wrote: > Checking both is one too much, so wrap a WARN_ON around it to stope > the copypasta. > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> > Cc: Haneen Mohammed <hamohammed.sa@xxxxxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx> > --- > drivers/gpu/drm/vkms/vkms_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > index 5fc8f85aaf3d..6d31265a2ab7 100644 > --- a/drivers/gpu/drm/vkms/vkms_plane.c > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > @@ -117,7 +117,7 @@ static int vkms_plane_atomic_check(struct drm_plane *plane, > bool can_position = false; > int ret; > > - if (!state->fb | !state->crtc) > + if (!state->fb || WARN_ON(!state->crtc)) > return 0; > > crtc_state = drm_atomic_get_crtc_state(state->state, state->crtc); > -- > 2.24.0 > Hi, Sorry, the delay in taking a look at this patch. I tried to find the whole series for getting the context related to this patch, but I could not find it in my mailbox. Could you shed some light here? Why check fb and crtc is too much? How the WARN_ON fix the issue? Best Regards Ps.: in the commit message: "stope" -> "stop" -- Rodrigo Siqueira Software Engineer, Advanced Micro Devices (AMD) https://siqueira.tech
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
