On Tue, 14 Jan 2020, Harry Wentland <hwentlan@xxxxxxx> wrote: > Fixing Nick's email. > > On 2020-01-10 5:43 p.m., Manasi Navare wrote: >> On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: >>> On Tue, 07 Jan 2020, Manasi Navare <manasi.d.navare@xxxxxxxxx> wrote: >>>> +EXPORT_SYMBOL(drm_get_adaptive_sync_limits); >>> >>> Why the export? Rather, why is this not static? >>> >> >> I could make it static but since the way AMDGPU code is written right now they >> would be calling this function explicitly to populate the vmin and vmax in their local >> structs but I can make it static and with some minor refactoring they should be able to >> use thsi infor directly from drm_display_info >> > > Calling this through drm_add_edid_modes should be sufficient for us. > We'll just need to move amdgpu_dm_update_freesync_caps to our get_modes > function. > > Dropping the export here seems to be the right thing to do. Thanks; this should help unify the behaviour across drivers. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
